From 685bc595407f7f2e680c886f04b7286c51c69e41 Mon Sep 17 00:00:00 2001
From: William JCM <w.jcm59@gmail.com>
Date: Fri, 2 Oct 2020 12:55:31 +0200
Subject: [PATCH] MassManager: return empty_string by ref instead of a temp
 object.

---
 MassManager/MassManager.cpp | 4 ++--
 MassManager/MassManager.h   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/MassManager/MassManager.cpp b/MassManager/MassManager.cpp
index e6f8e8c..ebbeed1 100644
--- a/MassManager/MassManager.cpp
+++ b/MassManager/MassManager.cpp
@@ -241,7 +241,7 @@ auto MassManager::stagedMasses() -> std::map<std::string, std::string> const& {
     return _stagedMasses;
 }
 
-auto MassManager::stagedMassName(int index) -> std::string {
+auto MassManager::stagedMassName(int index) -> std::string const& {
     int i = 0;
     for(const auto& mass_info : _stagedMasses) {
         if(i != index) {
@@ -252,7 +252,7 @@ auto MassManager::stagedMassName(int index) -> std::string {
         return mass_info.second;
     }
 
-    return std::string{""};
+    return empty_string;
 }
 
 auto MassManager::updateStagedMass(const std::string& filename) -> int {
diff --git a/MassManager/MassManager.h b/MassManager/MassManager.h
index d460638..846b8db 100644
--- a/MassManager/MassManager.h
+++ b/MassManager/MassManager.h
@@ -49,7 +49,7 @@ class MassManager {
 
         auto stagedMasses() -> std::map<std::string, std::string> const&;
 
-        auto stagedMassName(int index) -> std::string;
+        auto stagedMassName(int index) -> std::string const&;
 
         auto updateStagedMass(const std::string& filename) -> int;
         auto removeStagedMass(const std::string& filename) -> int;