Cleanup includes and improve code style.

src/Application/Application_FileWatcher.cpp

@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
+#include <cstring>
+
 #include <Corrade/Utility/Format.h>
 #include <Corrade/Utility/String.h>
 #include <Corrade/Utility/Unicode.h>

src/Application/Application_Initialisation.cpp

@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
+#include <cstring>
+
 #include <SDL_events.h>
 #include <SDL_messagebox.h>
 

src/Application/Application_MainManager.cpp

@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
+#include <cstring>
+
 #include <algorithm>
 
 #include <Corrade/Containers/ScopeGuard.h>

src/Application/Application_MassViewer.cpp

@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
+#include <cstring>
+
 #include <Corrade/Containers/ScopeGuard.h>
 #include <Corrade/Utility/Format.h>
 

src/Application/Application_MassViewer_Weapons.cpp

@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
+#include <cstring>
+
 #include "../FontAwesome/IconsFontAwesome5.h"
 
 #include "../GameData/StyleNames.h"

src/GameObjects/Mass.h

@@ -17,7 +17,6 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 #include <Corrade/Containers/Optional.h>
-#include <Corrade/Containers/Pointer.h>
 #include <Corrade/Containers/StaticArray.h>
 #include <Corrade/Containers/String.h>
 #include <Corrade/Containers/StringView.h>

src/Gvas/PropertySerialiser.h

@@ -16,7 +16,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
-#include <Corrade/Containers/GrowableArray.h>
+#include <Corrade/Containers/Array.h>
 #include <Corrade/Containers/String.h>
 #include <Corrade/Containers/StringView.h>
 

src/Managers/BackupManager.h

@@ -21,7 +21,7 @@
 #include <Corrade/Containers/String.h>
 #include <Corrade/Containers/StringView.h>
 
-#include <efsw/efsw.hpp>
+//#include <efsw/efsw.hpp>
 
 #include "Backup.h"
 #include "../GameObjects/Profile.h"
@@ -46,7 +46,7 @@ class BackupManager {
         bool create(const GameObjects::Profile& profile);
 
         bool remove(std::size_t index);
-        bool remove(Containers::StringView filename);
+        //bool remove(Containers::StringView filename);
 
         bool restore(std::size_t index);
 

src/Managers/MassManager.cpp

@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
+#include <cstring>
+
 #include <algorithm>
 
 #include <Corrade/Utility/Format.h>

src/Managers/ProfileManager.cpp

@@ -16,6 +16,7 @@
 
 #include <algorithm>
 
+#include <Corrade/Containers/GrowableArray.h>
 #include <Corrade/Containers/ScopeGuard.h>
 #include <Corrade/Containers/StaticArray.h>
 #include <Corrade/Utility/Format.h>

src/Managers/StagedMassManager.cpp

@@ -16,6 +16,7 @@
 
 #include <algorithm>
 
+#include <Corrade/Containers/GrowableArray.h>
 #include <Corrade/Containers/Optional.h>
 #include <Corrade/Utility/Path.h>
 

src/Version/Version.h

@@ -45,20 +45,19 @@ struct Version {
     bool prerelease  = false;
     long fullVersion = 0;
 
-    inline bool operator==(const Version& other) const {
+    bool operator==(const Version& other) const {
         return fullVersion == other.fullVersion && prerelease == other.prerelease;
     }
 
-    inline bool operator>(const Version& other) const {
+    bool operator>(const Version& other) const {
         if((fullVersion  > other.fullVersion) ||
            (fullVersion == other.fullVersion && !prerelease && other.prerelease))
         {
             return true;
         }
-        else {
+
         return false;
     }
-    }
 
     explicit operator Containers::String() const {
         return Utility::format("{}.{}.{}{}", major, minor, patch, prerelease ? "-pre" : "");