`fopen()` fails with paths that have non-ASCII characters #29

New issue

Closed

opened 2022-11-09 22:00:15 +01:00 by williamjcm · 1 comment

williamjcm commented

2022-11-09 22:00:15 +01:00

Owner

Windows being Windows.

Easiest fix is to switch from MSVCRT to UCRT and force the codepage for the app to be UTF-8.

According to the MS docs, just linking to a recent enough UCRT (Win SDK 1803 and up) and using setlocale(LC_ALL, ".UTF-8") is enough to get UTF-8 support, and that shipping the DLLs with the app would make it work on Win7/8/8.1.

But at the same time, Windows 7 and 8 are out of support, with 8.1 following on 2023-01-10, so I may as well just drop support for those at the same time.

Windows being Windows. Easiest fix is to switch from MSVCRT to UCRT and force the codepage for the app to be UTF-8. According to the MS docs, just linking to a recent enough UCRT (Win SDK 1803 and up) and using `setlocale(LC_ALL, ".UTF-8")` is enough to get UTF-8 support, and that shipping the DLLs with the app would make it work on Win7/8/8.1. But at the same time, Windows 7 and 8 are out of support, with 8.1 following on 2023-01-10, so I may as well just drop support for those at the same time.